xfs
[Top] [All Lists]

Re: [PATCH] Fix xfs build error on ia64 (mismatch section for xfs_qm_exi

To: "Luck, Tony" <tony.luck@xxxxxxxxx>
Subject: Re: [PATCH] Fix xfs build error on ia64 (mismatch section for xfs_qm_exit())
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 26 Mar 2012 12:12:56 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4f709c9a30285611d@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <4f709c9a30285611d@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Mar 26, 2012 at 09:43:06AM -0700, Luck, Tony wrote:
> ia64 deletes __exit section during the final link stage of vmlinux.
> This means that code should not call __exit functions in modules
> that can be built in to the kernel.
> 
> Building with CONFIG_DEBUG_SECTION_MISMATCH=y we see these build messages:
> 
> WARNING: vmlinux.o(.init.text+0x22462): Section mismatch in reference from 
> the function init_xfs_fs() to the function .exit.text:xfs_qm_exit()
> The function __init init_xfs_fs() references
> a function __exit xfs_qm_exit().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> xfs_qm_exit() so it may be used outside an exit section.
> 
> ...
> 
> `xfs_qm_exit' referenced in section `.init.text' of fs/built-in.o: defined in 
> discarded section `.exit.text' of fs/built-in.o
> make: *** [.tmp_vmlinux1] Error 1
> 
> Introduced in commit a05931ceb0160deadbd7798d60d01b17f2d81b09
>     xfs: remove the global xfs_Gqm structure
> 
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>

Thanks Tony,

We have a patch from Gerard Snitselaar that fixes this.

Regards,
        Ben

<Prev in Thread] Current Thread [Next in Thread>