xfs
[Top] [All Lists]

Re: [PATCH 8/8] xfs: add lots of attribute trace points

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 8/8] xfs: add lots of attribute trace points
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 24 Mar 2012 09:42:06 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1332393313-1955-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1332393313-1955-1-git-send-email-david@xxxxxxxxxxxxx> <1332393313-1955-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 22, 2012 at 04:15:13PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good mostly good, minor comments below:

>       /*
> -      * Copy the attribute name and value into the new space.
> -      *

Why does this get removed?

>  
>  #define DEFINE_DIR2_EVENT(name) \
> -DEFINE_EVENT(xfs_dir2_class, name, \
> +DEFINE_EVENT(xfs_da_class, name, \
>       TP_PROTO(struct xfs_da_args *args), \
>       TP_ARGS(args))


> +#define DEFINE_ATTR_EVENT(name) \
> +DEFINE_EVENT(xfs_da_class, name, \
> +     TP_PROTO(struct xfs_da_args *args), \
> +     TP_ARGS(args))

> +#define DEFINE_DA_EVENT(name) \
> +DEFINE_EVENT(xfs_da_class, name, \
> +     TP_PROTO(struct xfs_da_args *args), \
> +     TP_ARGS(args))

We should use the DEFINE_DA_EVENT macro for all of these tracepoints,
instead of having two duplicates of it.

Also all the tracepoints should print of which fork we operate on,
which is useful at least for the ones in common code.

<Prev in Thread] Current Thread [Next in Thread>