xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix deadlock in xfs_rtfree_extent with kernel v3.x

To: Kamal Dasu <kdasu.kdev@xxxxxxxxx>
Subject: Re: [PATCH] xfs: fix deadlock in xfs_rtfree_extent with kernel v3.x
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 22 Mar 2012 14:59:43 -0500
Cc: xfs@xxxxxxxxxxx, cernekee@xxxxxxxxx
In-reply-to: <1329957699-20769-1-git-send-email-kdasu.kdev@xxxxxxxxx>
References: <kdasu.kdev@xxxxxxxxx> <1329957699-20769-1-git-send-email-kdasu.kdev@xxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Feb 22, 2012 at 07:41:39PM -0500, Kamal Dasu wrote:
> To fix the deadlock caused by recursively calling xfs_rtfree_extent
> 
>  - removed xfs_ilock() and xfs_trans_ijoin() from xfs_rtfree_extent(),
>    instead added asserts that the inode is locked and has an inode_item
>    attached to it.
>  - in xfs_bunmapi() when dealing with an inode with the rt flag
>    call xfs_ilock() and xfs_trans_ijoin() so that the
>    reference count is bumped on the inode and attached it to the
>    transaction before calling into xfs_bmap_del_extent, similar to
>    what we do in xfs_bmap_rtalloc.
> 
> Signed-off-by: Kamal Dasu <kdasu.kdev@xxxxxxxxx>

Kamal, this looks good to me.
Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfs: fix deadlock in xfs_rtfree_extent with kernel v3.x, Ben Myers <=