xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfs: remove log item from AIL in xfs_iflush after a shut

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/4] xfs: remove log item from AIL in xfs_iflush after a shutdown
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 22 Mar 2012 10:20:29 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120316175636.187265302@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120316175541.258282540@xxxxxxxxxxxxxxxxxxxxxx> <20120316175636.187265302@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 16, 2012 at 01:55:43PM -0400, Christoph Hellwig wrote:
> If a filesystem has been forced shutdown we are never going to write inodes
> to disk, which means the inode items will stay in the AIL until we free
> the inode. Currently that is not a problem, but a pending change requires us
> to empty the AIL before shutting down the filesystem. In that case leaving
> the inode in the AIL is lethal. Make sure to remove the log item from the AIL
> to allow emptying the AIL on shutdown filesystems.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks OK, but I'm just not sure that all the necessary places to
remove the inode from the AIL have been found. How did you find
them, and how can we validate them?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>