| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/4] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 22 Mar 2012 10:16:33 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20120316175635.995054821@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20120316175541.258282540@xxxxxxxxxxxxxxxxxxxxxx> <20120316175635.995054821@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 16, 2012 at 01:55:42PM -0400, Christoph Hellwig wrote: > If a filesystem has been forced shutdown we are never going to write dquots > to disk, which means the dquot items will stay in the AIL forever. > Currently that is not a problem, but a pending chance requires us to > empty the AIL before shutting down the filesystem, in which case this > behaviour is lethal. Make sure to remove the log item from the AIL > to allow emptying the AIL on shutdown filesystems. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks OK. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [GIT PULL] XFS update for 3.4-rc1, Linus Torvalds |
|---|---|
| Next by Date: | Re: [PATCH 2/4] xfs: remove log item from AIL in xfs_iflush after a shutdown, Dave Chinner |
| Previous by Thread: | [PATCH 1/4] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown, Christoph Hellwig |
| Next by Thread: | [PATCH 2/4] xfs: remove log item from AIL in xfs_iflush after a shutdown, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |