xfs
[Top] [All Lists]

Re: [PATCH 08/10] xfs: initialise xfssync work before running quotacheck

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/10] xfs: initialise xfssync work before running quotachecks
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 16 Mar 2012 12:07:41 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1331095828-28742-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1331095828-28742-1-git-send-email-david@xxxxxxxxxxxxx> <1331095828-28742-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/06/12 22:50, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

Because the mount process can run a quotacheck and consume lots of
inodes, we need to be able to run periodic inode reclaim during the
mount process. This will prevent running the system out of memory
during quota checks.

This essentially reverts 2bcf6e97, but that is safe to do now that
the quota sync code that was causing problems during long quotacheck
executions is now gone.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---
  fs/xfs/xfs_super.c |   15 ++++++++-------
  1 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 13fa0cf..150d8f4 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1343,22 +1343,22 @@ xfs_fs_fill_super(

        /*
         * Blow away any referenced inode in the filestreams cache.
@@ -1397,6 +1397,7 @@ xfs_fs_fill_super(
        xfs_flush_buftarg(mp->m_ddev_targp, 1);

        xfs_unmountfs(mp);
+       xfs_syncd_stop(mp);
        goto out_free_sb;
  }



Shouldn't the xfs_syncd_stop() preceed the xfs_unmountfs()?

xfs_unmountfs() calls xfs_free_perag() and there is an iterator in inode and data sync workers.

Mark Tinguely
<tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>