xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: Fix oops on IO error during xlog_recover_process_iun

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfs: Fix oops on IO error during xlog_recover_process_iunlinks()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 16 Mar 2012 09:07:01 +1100
Cc: Jan Kara <jack@xxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, stable@xxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20120315090800.GA2887@xxxxxxxxxxxxx>
References: <1331801705-1145-1-git-send-email-jack@xxxxxxx> <20120315090800.GA2887@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 15, 2012 at 05:08:00AM -0400, Christoph Hellwig wrote:
> > +           xfs_buf_hold(agibp);
> > +           xfs_buf_relse(agibp);
> 
> This is a very awkward way to write
> 
>               xfs_buf_unlock(agibp);

/me slaps forehead.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>