xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: Fix oops on IO error during xlog_recover_process_iun

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfs: Fix oops on IO error during xlog_recover_process_iunlinks()
From: Jan Kara <jack@xxxxxxx>
Date: Thu, 15 Mar 2012 10:19:12 +0100
Cc: Jan Kara <jack@xxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, stable@xxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20120315090800.GA2887@xxxxxxxxxxxxx>
References: <1331801705-1145-1-git-send-email-jack@xxxxxxx> <20120315090800.GA2887@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu 15-03-12 05:08:00, Christoph Hellwig wrote:
> > +           xfs_buf_hold(agibp);
> > +           xfs_buf_relse(agibp);
> 
> This is a very awkward way to write
> 
>               xfs_buf_unlock(agibp);
  Hmm, looking into the functions you are right. I'll change this.

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>