xfs
[Top] [All Lists]

Re: [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getb

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getbmap
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 14 Mar 2012 13:12:41 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1331095828-28742-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1331095828-28742-1-git-send-email-david@xxxxxxxxxxxxx> <1331095828-28742-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/06/12 22:50, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

xfs_getbmap uses for a large buffer for extents, which is kmalloc'd.
This can fail after the system has been running for some time as it
is a high order allocation. Add a fallback to vmalloc so that it
doesn't require contiguous memory and so won't randomly fail on
files with large extent lists.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


Also Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>