xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs: remove the per-filesystem list of dquots

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfs: remove the per-filesystem list of dquots
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 13 Mar 2012 16:58:45 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120313215409.GI5091@dastard>
References: <20120313085232.134690907@xxxxxxxxxxxxxxxxxxxxxx> <20120313085308.997632929@xxxxxxxxxxxxxxxxxxxxxx> <20120313200354.GI7762@xxxxxxx> <20120313215409.GI5091@dastard>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Mar 14, 2012 at 08:54:09AM +1100, Dave Chinner wrote:
> On Tue, Mar 13, 2012 at 03:03:54PM -0500, Ben Myers wrote:
> > On Tue, Mar 13, 2012 at 04:52:36AM -0400, Christoph Hellwig wrote:
> > > +         struct xfs_dquot *batch[XFS_DQ_LOOKUP_BATCH];
> > 
> > Eesh.. that probably doesn't need to go onto the stack.  I know we are
> > doing it elsewhere too, and that we also sometimes complain about other
> > peoples' stack usage.  Don't necessarily have to clean it up now,
> > though.  ;)
> 
> Actually, if we do the walk from the shrinker we can't reliably
> allocate it, so it has to go on the stack.

D'oh, I missed that idea completely in my review.  :/ 

<Prev in Thread] Current Thread [Next in Thread>