[Top] [All Lists]

Re: [PATCH 2/5] xfs: per-filesystem dquot LRU lists

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: per-filesystem dquot LRU lists
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 14 Mar 2012 08:50:21 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120313085308.631894051@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120313085232.134690907@xxxxxxxxxxxxxxxxxxxxxx> <20120313085308.631894051@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 13, 2012 at 04:52:34AM -0400, Christoph Hellwig wrote:
> Replace the global dquot lru lists with a per-filesystem one.
> Note that the shrinker isn't wire up to the per-superblock VFS shrinker
> infrastructure as would have problems summing up and splitting the counts
> for inodes and dquots.  I don't think this is a major problem as the quota
> cache isn't as interwinded with the inode cache as the dentry cache is,
> because an inode that is dropped from the cache will generally release
> a dquot reference, but most of the time it won't be the last one.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks sane.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>