xfs
[Top] [All Lists]

Re: [PATCH 4/8 v2] xfs: use common code for quota statistics

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 4/8 v2] xfs: use common code for quota statistics
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 14 Mar 2012 08:40:27 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120313152748.GG7762@xxxxxxx>
References: <20120220022815.018921977@xxxxxxxxxxxxxxxxxxxxxx> <20120220022904.060961294@xxxxxxxxxxxxxxxxxxxxxx> <20120221014809.GA18227@xxxxxxxxxxxxx> <20120312175519.GE7762@xxxxxxx> <20120313084241.GA359@xxxxxxxxxxxxx> <20120313152748.GG7762@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 13, 2012 at 10:27:48AM -0500, Ben Myers wrote:
> On Tue, Mar 13, 2012 at 04:42:42AM -0400, Christoph Hellwig wrote:
> > On Mon, Mar 12, 2012 at 12:55:19PM -0500, Ben Myers wrote:
> > > > +static int xqm_proc_show(struct seq_file *m, void *v)
> > > > +{
> > > > +       /* maximum; incore; ratio free to inuse; freelist */
> > > > +       seq_printf(m, "%d\t%d\t%d\t%u\n",
> > > > +                       0,
> > > > +                       counter_val(XFSSTAT_END_XQMSTAT),
> > > 
> > > This patch looks great.  It might break some PCP scripts, I'm not sure.
> > 
> > Why would it break them?  The existing stats are still kept around, and
> > new additions to the main stats file are expected to happen once in a
> > while.
> 
> I'm not sure that it would.  You've added a line to the common stats
> procfile, and the pmda might expect the xpc line immediately after ibt2.

IIRC the pmda triggers off the descriptor at the start of the line.
It ignores lines that it doesn't understand the descriptor for (like
all the v2 btree stats). I should probably update the pmda fo all
those stats....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>