xfs
[Top] [All Lists]

Re: [PATCH 4/8 v2] xfs: use common code for quota statistics

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/8 v2] xfs: use common code for quota statistics
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 13 Mar 2012 10:27:48 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120313084241.GA359@xxxxxxxxxxxxx>
References: <20120220022815.018921977@xxxxxxxxxxxxxxxxxxxxxx> <20120220022904.060961294@xxxxxxxxxxxxxxxxxxxxxx> <20120221014809.GA18227@xxxxxxxxxxxxx> <20120312175519.GE7762@xxxxxxx> <20120313084241.GA359@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Mar 13, 2012 at 04:42:42AM -0400, Christoph Hellwig wrote:
> On Mon, Mar 12, 2012 at 12:55:19PM -0500, Ben Myers wrote:
> > > +static int xqm_proc_show(struct seq_file *m, void *v)
> > > +{
> > > + /* maximum; incore; ratio free to inuse; freelist */
> > > + seq_printf(m, "%d\t%d\t%d\t%u\n",
> > > +                 0,
> > > +                 counter_val(XFSSTAT_END_XQMSTAT),
> > 
> > This patch looks great.  It might break some PCP scripts, I'm not sure.
> 
> Why would it break them?  The existing stats are still kept around, and
> new additions to the main stats file are expected to happen once in a
> while.

I'm not sure that it would.  You've added a line to the common stats
procfile, and the pmda might expect the xpc line immediately after ibt2.

I've made a note to take a look.

-Ben

<Prev in Thread] Current Thread [Next in Thread>