xfs
[Top] [All Lists]

Re: [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getb

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getbmap
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 12 Mar 2012 09:28:03 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1331095828-28742-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1331095828-28742-1-git-send-email-david@xxxxxxxxxxxxx> <1331095828-28742-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 07, 2012 at 03:50:22PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_getbmap uses for a large buffer for extents, which is kmalloc'd.
> This can fail after the system has been running for some time as it
> is a high order allocation. Add a fallback to vmalloc so that it
> doesn't require contiguous memory and so won't randomly fail on
> files with large extent lists.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>