xfs
[Top] [All Lists]

Re: [RFC PATCH v1 0/4] cgroup quota

To: Glauber Costa <glommer@xxxxxxxxxxxxx>
Subject: Re: [RFC PATCH v1 0/4] cgroup quota
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Sun, 11 Mar 2012 19:47:43 +0800
Cc: jack@xxxxxxx, Lezcano <daniel.lezcano@xxxxxxx>, Christopher Jones <christopher.jones@xxxxxxxxxx>, Li Zefan <lizf@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, tj@xxxxxxxxxx, Ben Myers <bpm@xxxxxxx>, Daniel@xxxxxxxxxxx, lxc-devel@xxxxxxxxxxxxxxxxxxxxx, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, cgroups@xxxxxxxxxxxxxxx, Chris Mason <chris.mason@xxxxxxxxxx>, tytso@xxxxxxx
In-reply-to: <4F5C933F.3000409@xxxxxxxxxxxxx>
Organization: Oracle
References: <4F59E78A.7060903@xxxxxxxxxx> <4F5C933F.3000409@xxxxxxxxxxxxx>
Reply-to: jeff.liu@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11
On 03/11/2012 07:57 PM, Glauber Costa wrote:

> On 03/09/2012 03:20 PM, Jeff Liu wrote:
>> Hello,
>>
>> Disk quota feature has been asked at LXC list from time to time.
>> Given that the project quota has already implemented in XFS for a long
>> time, and it was also in progress for EXT4.
>> So the major idea is to assign one or more project IDs(or tree ID?) to
>> container, but leaving quota setup via cgroup
>> config files, so all the tasks running at container could have project
>> quota constraints applied.
>>
>> I'd like to post an initial patch sets here, the stupid implements is
>> very simple and even crash me
>> in some cases, sorry! But I would like to submit it to get more
>> feedback to make sure I am going down
>> the right road. :)
>>
>> Let me introduce it now.
>>
>> 1. Setup project quota on XFS(enabled pquota) firstly.
>> For example, the "project100" is configured on "/xfs/quota_test"
>> directory.
>>
>> $ cat /etc/projects
>> 100:/xfs/quota_test
>>
>> $ cat /etc/projid
>> project100:100
>>
>> $ sudo xfs_quota -x -c 'report -p'
>> Project quota on /xfs (/dev/sda7)
>>                                 Blocks
>> Project ID       Used       Soft       Hard    Warn/Grace
>> ---------- --------------------------------------------------
>> project100          0          0          0     00 [--------]
>>
>> 2. Mount cgroup on /cgroup.
>> cgroup on /cgroup type cgroup (rw)
>>
>> After that, there will have a couple of quota.XXXX files presented at
>> /cgroup.
>> $ ls -l /cgroup/quota.*
>> --w------- 1 root root 0 Mar  9 18:27 /cgroup/quota.activate
>> --w------- 1 root root 0 Mar  9 18:27 /cgroup/quota.add_project
>> -r--r--r-- 1 root root 0 Mar  9 18:27 /cgroup/quota.all
>> --w------- 1 root root 0 Mar  9 18:27 /cgroup/quota.block_limit_in_bytes
>> --w------- 1 root root 0 Mar  9 18:27 /cgroup/quota.deactivate
>> --w------- 1 root root 0 Mar  9 18:27 /cgroup/quota.inode_limit
>> -r--r--r-- 1 root root 0 Mar  9 18:27 /cgroup/quota.projects
>> --w------- 1 root root 0 Mar  9 18:27 /cgroup/quota.remove_project
>> --w------- 1 root root 0 Mar  9 18:27
>> /cgroup/quota.reset_block_limit_in_bytes
>> --w------- 1 root root 0 Mar  9 18:27 /cgroup/quota.reset_inode_limit
>>
>> 3. To assign a project ID to container, just echo it to
>> quota.add_project as:
>> echo "project100:100">  /cgroup/quota.add_project
>>
>> To get a short list of the current projects assigned to container,
>> user can check quota.projects,
>> # cat /cgroup/quota.projects
>> Project ID (project100:100)    status: off
>>
>> The totally quota info can be check against quota.all, it will show
>> something like below:
>> # cat /cgroup/quota.all
>> Project ID (project100:100)    status: off
>>    block_soft_limit    9223372036854775807
>>    block_hard_limit    9223372036854775807
>>    block_max_usage    0
>>    block_usage    0
>>    inode_soft_limit    9223372036854775807
>>    inode_hard_limit    9223372036854775807
>>    inode_max_usage    0
>>    inode_usage    0
>>
>> Note that about "status: off", by default, a new assigned project will
>> in OFF state, user could
>> turn it on by echo the project ID to quota.activate as below:
>> # echo 100>  /cgroup/quota.activate
>> # cat /cgroup/quota.all
>> Project ID (project100:100)    status: on     *now  status changed.*
>>    block_soft_limit    9223372036854775807
>>    block_hard_limit    9223372036854775807
>>    block_max_usage    0
>>    block_usage    0
>>    inode_soft_limit    9223372036854775807
>>    inode_hard_limit    9223372036854775807
>>    inode_max_usage    0
>>    inode_usage    0
>>
>> But it will do nothing since without quota setup.
>>
>> 4. To configure quota via cgroup, user need to interact with
>> quota.inode_limit and quota.block_limit_in_bytes.
>> For now, I only add a simple inode quota check to XFS, it looks
>> something like below:
>>
>> # echo "100 2:4">>  /cgroup/quota.inode_limit
>> # cat /cgroup/quota.all
>> Project ID (project100:100)    status: on
>>    block_soft_limit    9223372036854775807
>>    block_hard_limit    9223372036854775807
>>    block_max_usage    0
>>    block_usage    0
>>    inode_soft_limit    2
>>    inode_hard_limit    4
>>    inode_max_usage    0
>>    inode_usage    0
>>
>> # for ((i=0; i<  6; i++)); do touch xfs/quota_test/test.$i; done
>>
>> Project ID (project100:100)    status: on
>>    block_soft_limit    9223372036854775807
>>    block_hard_limit    9223372036854775807
>>    block_max_usage    0
>>    block_usage    0
>>    inode_soft_limit    2
>>    inode_hard_limit    4
>>    inode_max_usage    4
>>    inode_usage    4
>>
>> Sorry again, above steps crashed me sometimes for now, it works just
>> for demo purpose. :)
>>
>> Any criticism and suggestions are welcome!
>>
> When I started reading through this, I had one question in mind:
> 
> "Why cgroups?"
> 
> After I read it, I have one question in mind:
> 
> "Why cgroups?"
> 
> It really seems like the wrong interface for that. Specially since you
> doesn't seem to be doing anything really clever to divide the charges,
> etc. You are basically using cgroups as an interface to configure
> quotas. And I see no reason whatsoever to do it. Quotas already have a
> very well-defined interface.
> 
> In summary, I don't see how creating a new cgroup will do us any good
> here, specially if we're doing it just for the configuration interface.
> 
> There are two pieces of the puzzle for container-quota: An outer quota,
> that the box admin applies to that container as a whole, and a container
> quota, that the container admin can apply to its user.
> 
> The outer quota does not need any relation with cgroups at all!
> As a matter of fact, we already have this feature, you just don't
> realize it: if you assume you have project quota, we just need to
> configure the project to start at the subtree the container starts.
> 
> so, for instance, if you have:
> /root/lxc-root/
> 
> Then you create a project quota ontop of it, and you're done.

Thanks for your comments!

I know project quota can be configured outside of a container just as
you mentioned above.

Actually, at the present time, what I am trying to do are:

Given that an outside storage path, it has already configured with a
specified project ID, and it was bind mounted into a container.

Now the user hope to setup quota limits on the bind mounted path inside
the container.  Assuming that the project ID has been attached to
container through cgroup interface, so that he don't need to configured
quota outsides(Exactly, sys admin can setup it outsides directly), just
specify them via cgroup file.

Further thoughts, again, assume a particular project ID has been
assigned to a container,  if the sys admin want to configure quota
limits outsides, his operations should be denied;  and the sys admin
even can not remove the project ID if it was already attached to a
container.

And also, if there has already a project quota limits enforced outsides
to a directly, but the user can still setup a smaller quota limit s
through cgroup ,those limits just mixed up, but the smaller quota only
be effected for those processes running at container.

> 
> What we really need here, is a way to have a privileged user inside a
> container to create normal quotas (user, group) that he can configure,
> and have this quota be always smaller than, say, a project quota defined
> for the container from the outside. But cgroups is hardly the interface,
> or place, for that: Usually, the processes inside the container won't
> have access to their cgroups. They will contain the limits they are
> entitled to, and we don't won't the processes to change that at will. So
> tying it to cgroups does not solve the fundamental problem, which is how
> we have the container admin to set up quotas...

Sigh, exactly, I need some time to understand your opinions.  Thanks again.


-Jeff

> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs


<Prev in Thread] Current Thread [Next in Thread>