Re: [PATCH V3] xfstests 279: test mkfs with various sector sizes & alignments

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Thu, Mar 08, 2012 at 04:25:03PM -0600, Eric Sandeen wrote:
> On 3/2/12 10:58 AM, Eric Sandeen wrote:
> > This test uses the scsi_debug module to test mkfs against
> > various physical & logical sector sizes, and with aligned
> > and unaligned devices.
> > 
> > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> > ---
> > 
> > Dave, I think this implements all your suggestions (in one way or
> > another...) except the non-modular scsi_debug.  I don't know
> > how to manipulate things like offset if it's built in, but
> > if you want to look... I don't see it.
> > 
> > V3: remove a couple stray/extra "tee" commands
> > 
> > I looked into doing a generic version of this but I think without
> > the sector size checking unique to xfs it's a little pointless.
> 
> Dave, think this is ok now?

Yup.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx