xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: allow -F in open args

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs_io: allow -F in open args
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu, 08 Mar 2012 16:37:51 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <4F593493.6010106@xxxxxxx>
References: <4F2AC948.1050909@xxxxxxxxxx> <4F592728.9060706@xxxxxxx> <4F5930BC.7040106@xxxxxxxxxx> <4F593493.6010106@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
On 3/8/12 4:37 PM, Mark Tinguely wrote:
> On 03/08/12 16:20, Eric Sandeen wrote:
>> Now that -F ("foreign") is automagic, we should no longer list
>> it in the help output for open, but we should still accept
>> it for compatibility; esp. as it is still in the case statement.
>> Oops.
>>
>> Reported-by: Mark Tinguely<tinguely@xxxxxxx>
>> Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
>> ---
>>
>> diff --git a/io/open.c b/io/open.c
>> index ac39ccc..46538ba 100644
>> --- a/io/open.c
>> +++ b/io/open.c
>> @@ -240,7 +240,6 @@ open_help(void)
>>   "\n"
>>   " Opens a file for subsequent use by all of the other xfs_io commands.\n"
>>   " With no arguments, open uses the stat command to show the current 
>> file.\n"
>> -" -F -- foreign filesystem file, disallow XFS-specific commands\n"
>>   " -a -- open with the O_APPEND flag (append-only mode)\n"
>>   " -d -- open with O_DIRECT (non-buffered IO, note alignment constraints)\n"
>>   " -f -- open with O_CREAT (create the file if it doesn't exist)\n"
>> @@ -274,7 +273,7 @@ open_f(
>>           return 0;
>>       }
>>
>> -    while ((c = getopt(argc, argv, "Racdfm:nrstx")) != EOF) {
>> +    while ((c = getopt(argc, argv, "FRacdfm:nrstx")) != EOF) {
>>           switch (c) {
>>           case 'F':
>>               /* Ignored / deprecated now, handled automatically */
>>
>>
> 
> Thank-you. Probably could take it out of the man page under the open I/O 
> command now too.

Gah.  With your blessing I'll commit that as well?

> Reviewed-by: Mark Tinguely
> 
> 

<Prev in Thread] Current Thread [Next in Thread>