xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: deprecate the "-F" foreign flag

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs_io: deprecate the "-F" foreign flag
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 08 Mar 2012 16:16:43 -0600
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4F592728.9060706@xxxxxxx>
References: <4F2AC948.1050909@xxxxxxxxxx> <4F592728.9060706@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
On 3/8/12 3:39 PM, Mark Tinguely wrote:
> On 02/02/12 11:35, Eric Sandeen wrote:

...

>> @@ -282,10 +274,10 @@ open_f(
>>           return 0;
>>       }
>>
>> -    while ((c = getopt(argc, argv, "FRacdfm:nrstx")) != EOF) {
>> +    while ((c = getopt(argc, argv, "Racdfm:nrstx")) != EOF) {
>>           switch (c) {
>>           case 'F':
>> -            flags |= IO_FOREIGN;
>> +            /* Ignored / deprecated now, handled automatically */
>>               break;
> 
> 
> The "-F" is still in the command line open's help in open.
> 
> cxfs_io> help open
> open [-acdrstx] [path] -- open the file specified by path
> 
>  opens a new file in the requested mode
> 
>  Example:
>  'open -cd /tmp/data' - creates/opens data file read-write for direct IO
> 
>  Opens a file for subsequent use by all of the other xfs_io commands.
>  With no arguments, open uses the stat command to show the current file.
>  -F -- foreign filesystem file, disallow XFS-specific commands
>  -a -- open with the O_APPEND flag (append-only mode)
>  -d -- open with O_DIRECT (non-buffered IO, note alignment constraints)
>  -f -- open with O_CREAT (create the file if it doesn't exist)
>  -m -- permissions to use in case a new file is created (default 0600)
>  -n -- open with O_NONBLOCK
>  -r -- open with O_RDONLY, the default is O_RDWR
>  -s -- open with O_SYNC
>  -t -- open with O_TRUNC (truncate the file to zero length if it exists)
>  -R -- mark the file as a realtime XFS file immediately after opening it
>  Note1: usually read/write direct IO requests must be blocksize aligned;
>         some kernels, however, allow sectorsize alignment for direct IO.
>  Note2: the bmap for non-regular files can be obtained provided the file
>         was opened correctly (in particular, must be opened read-only).
> 
> 
> The "F" was taken out of the command line's getopt(), so it can't be
> specified. I guess either put the "F" back in the the open.c getopt()
> or take it complete from the command line.

Ah crud, sorry.  Patch shortly.

-Eric

> xfs_io> open -F somefile
> open: invalid option -- 'F'
> open [-acdrstx] [path] -- open the file specified by path
> 
> Thanks,
> 
> --Mark Tinguely
> tinguely@xxxxxxx
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>