xfs
[Top] [All Lists]

Re: [PATCH 01/10] xfs: clean up minor sparse warnings

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/10] xfs: clean up minor sparse warnings
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 8 Mar 2012 15:34:10 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1331095828-28742-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1331095828-28742-1-git-send-email-david@xxxxxxxxxxxxx> <1331095828-28742-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Mar 07, 2012 at 03:50:19PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Ben Myers <bpm@xxxxxxx>

...

> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index ab30253..2601d6b 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -103,12 +103,15 @@ xfs_mark_inode_dirty(
>  }
>  
>  
> -int xfs_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> -                void *fs_info)
> +static int
> +xfs_initxattrs(
> +     struct inode            *inode,
> +     const struct xattr      *xattr_array,
> +     void                    *fs_info)
>  {
> -     const struct xattr *xattr;
> -     struct xfs_inode *ip = XFS_I(inode);
> -     int error = 0;
> +     const struct xattr      *xattr;
> +     struct xfs_inode        *ip = XFS_I(inode);
> +     int                     error = 0;

I didn't see a sparse warning which this fixes... FWICS all you've done
here is make it static and fix the formatting.

This still looks good..  ;)

<Prev in Thread] Current Thread [Next in Thread>