[Top] [All Lists]

Re: [PATCH] default to 64 bit inodes & add feature flag

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] default to 64 bit inodes & add feature flag
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 8 Mar 2012 12:34:13 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>, "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <4F5798F9.2050809@xxxxxxxxxx>
References: <4F5798F9.2050809@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 07, 2012 at 11:20:57AM -0600, Eric Sandeen wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> Default to allowing 64-bit inodes on the filesystem.
> Add a feature bit to the the superblock to record whether 64 bit inodes have
> been allocated on the filesystem or not. This allows us to reject mounting the
> filesytem with inode32 if 64 bit inodes are present.
> Once a 64 bitinode is allocated, the inode64 superblock feature bit will be 
> set.
> Once the superblock feature bit is set, the filesystem will default to 64 bit
> inodes regardless of whether inode64 is specified as a mount option.
> To ensure only 32 bit inodes are created, the inode32 mount option must be
> used. If there are already 64 bit inodes as flagged by the superblock feature
> bit, then the inode32 mount will be refused.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
> Passing this along to revive the old discussion ... 

I have no objections to do this. However, the kernel patch is just
the tip of the iceberg when it comes to implementing this.

Were there patches for userspace support of the feature bit? I don't
recall if there were. I'm thinking that xfs_info needs to output
whether this is set, which means the flag needs to be added to the
xfs geometry ioctls in the kernel.

I'd also think that this should also be made a mkfs option (it will
have to default to "not enabled" for a couple of years until distro
kernels catch up) along with outputting the current value. This
will then require xfstests mkfs filter changes, too.

We'll also need xfs_check, xfs_db (e.g. the version command) and
xfs_repair knowledge of the new feature bit so they don't think the
superblock is corrupted when this new bit gets set....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>