xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 7 Mar 2012 15:02:53 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120229095509.185485494@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120229095347.009884687@xxxxxxxxxxxxxxxxxxxxxx> <20120229095509.185485494@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Feb 29, 2012 at 04:53:53AM -0500, Christoph Hellwig wrote:
> Move all code messing with the inode log item flags into xfs_inode_item_format
> to make sure xfs_inode_item_size really only calculates the the number of
> vectors, but doesn't modify any state of the inode item.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>