Re: [PATCH] default to 64 bit inodes & add feature flag

[Arkadiusz Miśkiewicz <arekm@xxxxxxxx>]

On Wednesday 07 of March 2012, Josef 'Jeff' Sipek wrote:
> On Wed, Mar 07, 2012 at 11:20:57AM -0600, Eric Sandeen wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Default to allowing 64-bit inodes on the filesystem.
> > 
> > Add a feature bit to the the superblock to record whether 64 bit inodes
> > have been allocated on the filesystem or not. This allows us to reject
> > mounting the filesytem with inode32 if 64 bit inodes are present.
> > 
> > Once a 64 bitinode is allocated, the inode64 superblock feature bit will
> > be set. Once the superblock feature bit is set, the filesystem will
> > default to 64 bit inodes regardless of whether inode64 is specified as a
> > mount option.
> > 
> > To ensure only 32 bit inodes are created, the inode32 mount option must
> > be used. If there are already 64 bit inodes as flagged by the superblock
> > feature bit, then the inode32 mount will be refused.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Love it! 

+1 for love. I had too many problems with forgetting to mount with inode64 
option.

-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/