xfs
[Top] [All Lists]

Re: [PATCH] xfstests: before test execution, print test number to syslog

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: before test execution, print test number to syslog
From: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Date: Mon, 05 Mar 2012 18:32:17 +0100
Cc: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1330968739; l=1222; s=domk; d=giantdisaster.de; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Subject:CC:To:MIME-Version:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=Z57uESd9NfyKOjMKLCJnOCFTiLU=; b=FUoEnilbgjDOCO5W70JuMPNDldlSwF6gnDQv2U7h0XUrjm6ygY/RslivjO+ZsbIH3Rl pVvyNU700OsYkf6tBDMJo4XpNv+FHfNGIX3VKqlF+dcAKCcGlBQhFzQHyN4lhTTdzaj1u +xRRWyeC+z5gfEmSDxgAAwj6Noldkx3R+lQ=
In-reply-to: <20120305012301.GM5091@dastard>
References: <1330691215-4796-1-git-send-email-sbehrens@xxxxxxxxxxxxxxxx> <20120305012301.GM5091@dastard>
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
On 3/5/2012 2:23 AM, Dave Chinner wrote:
> On Fri, Mar 02, 2012 at 01:26:55PM +0100, Stefan Behrens wrote:
>> When the xfstests are executed in a batch (like "check 001-299")
>> and produce syslog output, it is helpful to know which test was
>> causing the output. Therefore each time a test is started, a
>> syslog message is generated that contains the number of the
>> xfstest.
>>
>> Signed-off-by: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
>> ---
>>  check |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/check b/check
>> index f792009..883edcc 100755
>> --- a/check
>> +++ b/check
>> @@ -241,6 +241,7 @@ do
>>      start=`_wallclock`
>>      $timestamp && echo -n " ["`date "+%T"`"]"
>>      [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>> +    logger "run xfstest $seq"
>>      ./$seq >$tmp.rawout 2>&1
>>      sts=$?
>>      $timestamp && _timestamp
> 
> Only thing I'd suggest here is that errors (e.g. logger is not
> installed) are redirected to /dev/null so there isn't additional
> noise if we fail to log to syslog.

Patch v2 is sent which checks that logger can be executed. Additional
output cannot happen according to the sources. Thanks!


> 
> Cheers,
> 
> Dave.

<Prev in Thread] Current Thread [Next in Thread>