xfs
[Top] [All Lists]

Re: [PATCH] xfstests: before test execution, print test number to syslog

To: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: before test execution, print test number to syslog
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 5 Mar 2012 12:23:01 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1330691215-4796-1-git-send-email-sbehrens@xxxxxxxxxxxxxxxx>
References: <1330691215-4796-1-git-send-email-sbehrens@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 02, 2012 at 01:26:55PM +0100, Stefan Behrens wrote:
> When the xfstests are executed in a batch (like "check 001-299")
> and produce syslog output, it is helpful to know which test was
> causing the output. Therefore each time a test is started, a
> syslog message is generated that contains the number of the
> xfstest.
> 
> Signed-off-by: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
> ---
>  check |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/check b/check
> index f792009..883edcc 100755
> --- a/check
> +++ b/check
> @@ -241,6 +241,7 @@ do
>       start=`_wallclock`
>       $timestamp && echo -n " ["`date "+%T"`"]"
>       [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
> +     logger "run xfstest $seq"
>       ./$seq >$tmp.rawout 2>&1
>       sts=$?
>       $timestamp && _timestamp

Only thing I'd suggest here is that errors (e.g. logger is not
installed) are redirected to /dev/null so there isn't additional
noise if we fail to log to syslog.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>