xfs
[Top] [All Lists]

Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 03 Mar 2012 13:03:56 -0600
Cc: Jeff Moyer <jmoyer@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20120303093332.GA8417@xxxxxxxxxxxxx>
References: <x49ipim7r19.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20120303093332.GA8417@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
On 3/3/12 3:33 AM, Christoph Hellwig wrote:
> On Fri, Mar 02, 2012 at 02:15:46PM -0500, Jeff Moyer wrote:
>> Hi,
>>
>> This patch adds a couple more aio-stress runs to test 113.  The first
>> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
>> 2, which directs aio-stress to only perform the random write test.
>> These two tests helped identify several bugs in ext4.
> 
> I'd rather make this a separate testcase, maybe moving the _do_test into
> common code.
> 
> Rationale:  newly added tests shouldn't make old testcases fail, as that
> would be rather confusing.

Well, phooey, I committed it already.

I can do another patch to revert & add to a new test if you really want.

-Eric

> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>