xfs
[Top] [All Lists]

Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC

To: Jeff Moyer <jmoyer@xxxxxxxxxx>
Subject: Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 3 Mar 2012 04:33:32 -0500
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <x49ipim7r19.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <x49ipim7r19.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 02, 2012 at 02:15:46PM -0500, Jeff Moyer wrote:
> Hi,
> 
> This patch adds a couple more aio-stress runs to test 113.  The first
> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
> 2, which directs aio-stress to only perform the random write test.
> These two tests helped identify several bugs in ext4.

I'd rather make this a separate testcase, maybe moving the _do_test into
common code.

Rationale:  newly added tests shouldn't make old testcases fail, as that
would be rather confusing.

<Prev in Thread] Current Thread [Next in Thread>