xfs
[Top] [All Lists]

Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC

To: Jeff Moyer <jmoyer@xxxxxxxxxx>
Subject: Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 02 Mar 2012 14:15:49 -0600
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <x49ipim7r19.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <x49ipim7r19.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
On 3/2/12 1:15 PM, Jeff Moyer wrote:
> Hi,
> 
> This patch adds a couple more aio-stress runs to test 113.  The first
> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
> 2, which directs aio-stress to only perform the random write test.
> These two tests helped identify several bugs in ext4.
> 
> Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks fine, I'll check it into xfstests-dev, thanks!

-Eric

> 
> diff --git a/113 b/113
> index 23676e0..b2ec510 100755
> --- a/113
> +++ b/113
> @@ -100,4 +100,10 @@ _do_test 2 "-s 10m" $count $procs
>  # as above, but now using direct IO
>  _do_test 3 "-s 10m -O" $count $procs
>  
> +# dio with O_SYNC and unwritten extent conversion
> +_do_test 4 "-s 10m -O -S" $count $procs
> +
> +# random dio writes with O_SYNC and unwritten extent conversion
> +_do_test 5 "-s 10m -O -S -o 2" $count $procs
> +
>  exit
> diff --git a/113.out b/113.out
> index 1f3b866..aa856a6 100644
> --- a/113.out
> +++ b/113.out
> @@ -12,3 +12,11 @@ aio-stress.2 : -t 20 -s 10m
>  -----------------------------------------------
>  aio-stress.3 : -t 20 -s 10m -O
>  -----------------------------------------------
> +
> +-----------------------------------------------
> +aio-stress.4 : -t 20 -s 10m -O -S
> +-----------------------------------------------
> +
> +-----------------------------------------------
> +aio-stress.5 : -t 20 -s 10m -O -S -o 2
> +-----------------------------------------------
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>