xfs
[Top] [All Lists]

Re: [PATCH] xfstests: before test execution, print test number to syslog

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: before test execution, print test number to syslog
From: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Date: Fri, 02 Mar 2012 16:27:16 +0100
Cc: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1330702042; l=1160; s=domk; d=giantdisaster.de; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Subject:CC:To:MIME-Version:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=UANQTCXCBqeQ9lQI++8I9dhbZAs=; b=EJ1lijEXpTtfddBhA1i4yzlIW0IhErM1RwtOnywCQt2NfBbCGRN6DJZmFblTcAHDw3J KUAe6LNeUYc4NygW8MSlSvSfCDhnOsur0FpP6+Pg5S4d4Rpb0WUfunKng3zI9fDYT2riq +fAszOfBbclu5S0mwI1s+yXSdvSDlewL6iY=
In-reply-to: <4F50DFEF.60401@xxxxxxxxxxx>
References: <1330691215-4796-1-git-send-email-sbehrens@xxxxxxxxxxxxxxxx> <4F50DFEF.60401@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
On 3/2/2012 3:57 PM, Eric Sandeen wrote:
> On 3/2/12 6:26 AM, Stefan Behrens wrote:
>> When the xfstests are executed in a batch (like "check 001-299")
>> and produce syslog output, it is helpful to know which test was
>> causing the output. Therefore each time a test is started, a
>> syslog message is generated that contains the number of the
>> xfstest.
>>
>> Signed-off-by: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
> 
> I like this; I almost sent a similar patch once.
> 
> But would like to let others chime in as well to be sure.
> 
> Is "logger" universal and portable to other systems?  That'd be
> my only concern with the patch.

logger(1) is included in the POSIX specification.


> 
> -Eric
> 
>> ---
>>  check |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/check b/check
>> index f792009..883edcc 100755
>> --- a/check
>> +++ b/check
>> @@ -241,6 +241,7 @@ do
>>      start=`_wallclock`
>>      $timestamp && echo -n " ["`date "+%T"`"]"
>>      [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>> +    logger "run xfstest $seq"
>>      ./$seq >$tmp.rawout 2>&1
>>      sts=$?
>>      $timestamp && _timestamp

<Prev in Thread] Current Thread [Next in Thread>