xfs
[Top] [All Lists]

Re: [PATCH] xfstests: before test execution, print test number to syslog

To: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: before test execution, print test number to syslog
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 02 Mar 2012 08:57:51 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1330691215-4796-1-git-send-email-sbehrens@xxxxxxxxxxxxxxxx>
References: <1330691215-4796-1-git-send-email-sbehrens@xxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
On 3/2/12 6:26 AM, Stefan Behrens wrote:
> When the xfstests are executed in a batch (like "check 001-299")
> and produce syslog output, it is helpful to know which test was
> causing the output. Therefore each time a test is started, a
> syslog message is generated that contains the number of the
> xfstest.
> 
> Signed-off-by: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>

I like this; I almost sent a similar patch once.

But would like to let others chime in as well to be sure.

Is "logger" universal and portable to other systems?  That'd be
my only concern with the patch.

-Eric

> ---
>  check |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/check b/check
> index f792009..883edcc 100755
> --- a/check
> +++ b/check
> @@ -241,6 +241,7 @@ do
>       start=`_wallclock`
>       $timestamp && echo -n " ["`date "+%T"`"]"
>       [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
> +     logger "run xfstest $seq"
>       ./$seq >$tmp.rawout 2>&1
>       sts=$?
>       $timestamp && _timestamp

<Prev in Thread] Current Thread [Next in Thread>