[Top] [All Lists]

Re: [PATCH 8/8] xfs: add a shrinker for quotacheck

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 8/8] xfs: add a shrinker for quotacheck
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 2 Mar 2012 21:04:26 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120302075104.GG4117@xxxxxxxxxxxxx>
References: <1330661507-1121-1-git-send-email-david@xxxxxxxxxxxxx> <1330661507-1121-9-git-send-email-david@xxxxxxxxxxxxx> <20120302075104.GG4117@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 02, 2012 at 02:51:04AM -0500, Christoph Hellwig wrote:
> Hmm, I don't like this complication all that much.

Though it is a simple, self contained fix for the problem...

> Why would we even bother caching inodes during quotacheck?  The bulkstat
> is a 100% sequential read only workload going through all inodes in the
> filesystem.  I think we should simply not cache any inodes while in
> quotacheck.

I have tried that approach previously with inodes read through
bulkstat, but I couldn't find a clean workable solution. It kept
getting rather complex because all our caching and recycling is tied
into VFS level triggers. That was a while back, so maybe there is a
simpler solution that I missed in attempting to do this.

I suspect for a quotacheck only solution we can hack a check into
.drop_inode, but a generic coherent non-cached bulkstat lookup is
somewhat more troublesome.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>