[Top] [All Lists]

Re: [PATCH 1/8] xfs: clean up minor sparse warnings

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfs: clean up minor sparse warnings
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 2 Mar 2012 18:59:54 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120302074642.GC4117@xxxxxxxxxxxxx>
References: <1330661507-1121-1-git-send-email-david@xxxxxxxxxxxxx> <1330661507-1121-2-git-send-email-david@xxxxxxxxxxxxx> <20120302074642.GC4117@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 02, 2012 at 02:46:42AM -0500, Christoph Hellwig wrote:
> On Fri, Mar 02, 2012 at 03:11:40PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> Why do you use this double from line?  It confuses all the patch apply
> scripts.

I didn't. It looks like the current version of guilt is busted
or doesn't work correctly with the current version of git. Basically
guilt hasn't stripped the From line out of the patch description
when using it for the commit message, so it's getting set by
git-send-email as well as being included in the commit message. It
must have broken when I updated everything last week...

I'll have a look at it and repost when I find out why it's now


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>