xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfsprogs: replace deprecated ustat call with statfs in l

To: Kamal Dasu <kdasu.kdev@xxxxxxxxx>
Subject: Re: [PATCH 1/2] xfsprogs: replace deprecated ustat call with statfs in libxfs/linux.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 2 Mar 2012 02:45:58 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <de74feb44ebd887269fe85d9a5879765afccf4c2.1330635228.git.kdasu.kdev@xxxxxxxxx>
References: <1330636285-11200-1-git-send-email-kdasu.kdev@xxxxxxxxx> <de74feb44ebd887269fe85d9a5879765afccf4c2.1330635228.git.kdasu.kdev@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 01, 2012 at 04:11:24PM -0500, Kamal Dasu wrote:
> >From the ustat man page
> 
> NOTES
>        ustat() is deprecated and has only  been  provided  for  compatibility.
>        All new programs should use statfs(2) instead.

xfsprogs isn't new :)

More seriously - ustat provides the benefit to check if the block device
is mounted anywhere, which we make use of here.  A statfs of the block
device path doesn't provide that functionality at all.

<Prev in Thread] Current Thread [Next in Thread>