[Top] [All Lists]

[XFS updates] XFS development tree branch, for-linus, updated. v3.2-rc1-

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, for-linus, updated. v3.2-rc1-11438-g5cfc459
From: xfs@xxxxxxxxxxx
Date: Wed, 29 Feb 2012 21:30:52 -0600
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, for-linus has been updated
  5cfc459 xfs: fix inode lookup race
      from  c922bbc819324558e61402a7a76c10c550ca61bc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5cfc459ec18d1f0bbf6971966d35cdb8e66cfbbc
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Wed Feb 29 21:22:40 2012 -0600

    xfs: fix inode lookup race
    When we get concurrent lookups of the same inode that is not in the
    per-AG inode cache, there is a race condition that triggers warnings
    in unlock_new_inode() indicating that we are initialising an inode
    that isn't in a the correct state for a new inode.
    When we do an inode lookup via a file handle or a bulkstat, we don't
    serialise lookups at a higher level through the dentry cache (i.e.
    pathless lookup), and so we can get concurrent lookups of the same
    The race condition is between the insertion of the inode into the
    cache in the case of a cache miss and a concurrently lookup:
    Thread 1                    Thread 2
        lock radix tree
                                lock inode flags
                                XFS_INEW not set
                                unlock inode flags
                                use uninitialised inode
        lock inode flags
        set XFS_INEW
        unlock inode flags
        unlock radix tree
        inode flags = I_NEW
          WARNING as inode flags != I_NEW
    This can lead to inode corruption, inode list corruption, etc, and
    is generally a bad thing to occur.
    Fix this by setting XFS_INEW before inserting the inode into the
    radix tree. This will ensure any concurrent lookup will find the new
    inode with XFS_INEW set and that forces the lookup to wait until the
    XFS_INEW flag is removed before allowing the lookup to succeed.
    Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Ben Myers <bpm@xxxxxxx>


Summary of changes:
 fs/xfs/xfs_iget.c |   17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)

XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, for-linus, updated. v3.2-rc1-11438-g5cfc459, xfs <=