xfs
[Top] [All Lists]

Re: [PATCH 4/8] xfs: log file size updates at I/O completion time

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/8] xfs: log file size updates at I/O completion time
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 29 Feb 2012 15:21:09 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120229095508.812609910@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120229095347.009884687@xxxxxxxxxxxxxxxxxxxxxx> <20120229095508.812609910@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/29/12 03:53, Christoph Hellwig wrote:
Do not use unlogged metadata updates and the VFS dirty bit for updating
the file size after writeback.  In addition to causing various problems
with updates getting delayed for far too long this also drags in the
unscalable VFS dirty tracking, and is one of the few remaining unlogged
metadata updates.

Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>
Signed-off-by: Christoph Hellwig<hch@xxxxxx>


Looks good. It took me a while to figure out the PF_FSTRANS clearing in the xfs_setfilesize_trans_alloc() routine.

Reviewed-by: Mark Tinguely

<Prev in Thread] Current Thread [Next in Thread>