Re: [PATCH 4/8] xfs: log file size updates at I/O completion time

xfs

Re: [PATCH 4/8] xfs: log file size updates at I/O completion time

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/8] xfs: log file size updates at I/O completion time
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Wed, 29 Feb 2012 15:21:09 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120229095508.812609910@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20120229095347.009884687@xxxxxxxxxxxxxxxxxxxxxx> <20120229095508.812609910@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 02/29/12 03:53, Christoph Hellwig wrote:

Do not use unlogged metadata updates and the VFS dirty bit for updating
the file size after writeback.  In addition to causing various problems
with updates getting delayed for far too long this also drags in the
unscalable VFS dirty tracking, and is one of the few remaining unlogged
metadata updates.

Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>
Signed-off-by: Christoph Hellwig<hch@xxxxxx>

Looks good. It took me a while to figure out the PF_FSTRANS clearing inthe xfs_setfilesize_trans_alloc() routine.


Reviewed-by: Mark Tinguely

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/8] log all inode updates V3, Christoph Hellwig [PATCH 6/8] xfs: make xfs_inode_item_size idempotent, Christoph Hellwig [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Christoph Hellwig [PATCH 4/8] xfs: log file size updates at I/O completion time, Christoph Hellwig Re: [PATCH 4/8] xfs: log file size updates at I/O completion time, Mark Tinguely <= [PATCH 3/8] xfs: log file size updates as part of unwritten extent conversion, Christoph Hellwig Re: [PATCH 3/8] xfs: log file size updates as part of unwritten extent conversion, Mark Tinguely [PATCH 8/8] xfs: reimplement fdatasync support, Christoph Hellwig [PATCH 5/8] xfs: log timestamp updates, Christoph Hellwig [PATCH 2/8] xfs: do not require an ioend for new EOF calculation, Christoph Hellwig [PATCH 7/8] xfs: split in-core and on-disk inode log item fields, Christoph Hellwig

Previous by Date:	Bug#661580: mkfs.xfs fails to detect correct sector size, Eric Sandeen
Next by Date:	[XFS updates] XFS development tree branch, master, updated. v3.2-rc1-11460-g4b217ed, xfs
Previous by Thread:	[PATCH 4/8] xfs: log file size updates at I/O completion time, Christoph Hellwig
Next by Thread:	[PATCH 3/8] xfs: log file size updates as part of unwritten extent conversion, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]