xfs
[Top] [All Lists]

Re: [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquot

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 29 Feb 2012 11:40:19 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120228032740.GA18306@xxxxxxxxxxxxx>
References: <20120220022815.018921977@xxxxxxxxxxxxxxxxxxxxxx> <20120220022903.488870885@xxxxxxxxxxxxxxxxxxxxxx> <20120227015941.GI7762@xxxxxxx> <20120227171727.GA22046@xxxxxxxxxxxxx> <20120227172310.GH28391@xxxxxxx> <20120228032740.GA18306@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Feb 27, 2012 at 10:27:40PM -0500, Christoph Hellwig wrote:
> On Mon, Feb 27, 2012 at 11:23:10AM -0600, Ben Myers wrote:
> > On Mon, Feb 27, 2012 at 12:17:27PM -0500, Christoph Hellwig wrote:
> > > > I should have replied to this patch, not the older rev.
> > > > 
> > > > I have a question about the error code, now we're not mapping errors to
> > > > EFAULT and we used do... which is correct?
> > > 
> > > The old one looks finshy, but we even if we changed it it should be
> > > in a separate patch with a good description.  I'll resend with this bit
> > > fixed.
> > 
> > Sounds great.  ;)
> 
> Actually the patch is fine as-is.  If you look at the old
> xfs_qm_scall_getquota we'd return any error we get from xfs_qm_dqget
> as-is, and return ENOENT if XFS_IS_DQUOT_UNINITIALIZED is true.  The
> place where any other error is converted to EFAULT is never actually
> reached.

Apologies.. I see it now.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>