Re: [PATCH 2/8] xfs: do not require an ioend for new EOF calculation

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 2/8] xfs: do not require an ioend for new EOF calculation
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Tue, 28 Feb 2012 10:14:27 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120221003906.313004161@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20120221003824.415885674@xxxxxxxxxxxxxxxxxxxxxx> <20120221003906.313004161@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 02/20/12 18:38, Christoph Hellwig wrote:

Replace xfs_ioend_new_eof with a new inline xfs_new_eof helper that
doesn't require and ioend, and is available also outside of xfs_aops.c.

Also make the code a bit more clear by using a normal if statement
instead of a slightly misleading MIN().

Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>
Signed-off-by: Christoph Hellwig<hch@xxxxxx>


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 3/8] xfs: log file size updates as part of unwritten extent conversion, (continued) [PATCH 3/8] xfs: log file size updates as part of unwritten extent conversion, Christoph Hellwig [PATCH 4/8] xfs: log file size updates at I/O completion time, Christoph Hellwig Re: [PATCH 4/8] xfs: log file size updates at I/O completion time, Dave Chinner Re: [PATCH 4/8] xfs: log file size updates at I/O completion time, Christoph Hellwig [PATCH 8/8] xfs: add back fdatasync support, Christoph Hellwig Re: [PATCH 8/8] xfs: add back fdatasync support, Dave Chinner [PATCH 6/8] xfs: make xfs_inode_item_size idempotent, Christoph Hellwig Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent, Dave Chinner Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent, Christoph Hellwig [PATCH 2/8] xfs: do not require an ioend for new EOF calculation, Christoph Hellwig Re: [PATCH 2/8] xfs: do not require an ioend for new EOF calculation, Mark Tinguely <= [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Christoph Hellwig Re: [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Dave Chinner Re: [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Mark Tinguely [PATCH 7/8] xfs: split in-core and on-disk inode log item fields, Christoph Hellwig Re: [PATCH 7/8] xfs: split in-core and on-disk inode log item fields, Dave Chinner [PATCH 5/8] xfs: log timestamp updates, Christoph Hellwig Re: [PATCH 5/8] xfs: log timestamp updates, Dave Chinner

Previous by Date:	Re: [PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Mark Tinguely
Next by Date:	[PATCH 1/2] repair: fix the variable-width nlink array, Christoph Hellwig
Previous by Thread:	[PATCH 2/8] xfs: do not require an ioend for new EOF calculation, Christoph Hellwig
Next by Thread:	[PATCH 1/8] xfs: use per-filesystem I/O completion workqueues, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]