xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/8] xfs: make xfs_inode_item_size idempotent
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 28 Feb 2012 06:08:58 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120221051404.GM3592@dastard>
References: <20120221003824.415885674@xxxxxxxxxxxxxxxxxxxxxx> <20120221003907.081625923@xxxxxxxxxxxxxxxxxxxxxx> <20120221051404.GM3592@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 21, 2012 at 04:14:04PM +1100, Dave Chinner wrote:
> One minor cleanup:
> 
> >     case XFS_DINODE_FMT_LOCAL:
> > -           ASSERT(!(iip->ili_format.ilf_fields &
> > -                    (XFS_ILOG_ABROOT | XFS_ILOG_AEXT)));
> > -           if (iip->ili_format.ilf_fields & XFS_ILOG_ADATA) {
> > +           iip->ili_format.ilf_fields &=
> > +                   ~(XFS_ILOG_AEXT | XFS_ILOG_ABROOT);
> > +
> > +           if ((iip->ili_format.ilf_fields & XFS_ILOG_ADATA) &&
> > +               ip->i_afp->if_bytes > 0) {
> >                     ASSERT(ip->i_afp->if_bytes > 0);
> 
> That assert can go - it's checked in the if statement now.

Fixed.

<Prev in Thread] Current Thread [Next in Thread>