xfs
[Top] [All Lists]

Re: [PATCH 4/8] xfs: log file size updates at I/O completion time

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/8] xfs: log file size updates at I/O completion time
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 28 Feb 2012 06:07:13 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120221050526.GK3592@dastard>
References: <20120221003824.415885674@xxxxxxxxxxxxxxxxxxxxxx> <20120221003906.670163670@xxxxxxxxxxxxxxxxxxxxxx> <20120221050526.GK3592@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Feb 21, 2012 at 04:05:26PM +1100, Dave Chinner wrote:
> Hmmm, I missed something here first time through: do we need to
> restore the PF_FSTRANS flag here before cancelling the transaction?
> I don't think we do (clearing a flag that is aready cleared is not a
> problem), but we should be consistent with the IO completion
> handling of this transaction.

I don't think we'll need it either, but I'll fix it up anyway.

<Prev in Thread] Current Thread [Next in Thread>