xfs
[Top] [All Lists]

Re: [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquot

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota
From: Ben Myers <bpm@xxxxxxx>
Date: Sun, 26 Feb 2012 19:59:41 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120220022903.488870885@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120220022815.018921977@xxxxxxxxxxxxxxxxxxxxxx> <20120220022903.488870885@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
Hi Christoph,

On Sun, Feb 19, 2012 at 09:28:16PM -0500, Christoph Hellwig wrote:
> The is no good reason to have these two separate, and for the next change
> we would need the full struct xfs_dquot in xfs_qm_export_dquot, so better
> just fold the code now instead of changing it spuriously.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

I should have replied to this patch, not the older rev.

I have a question about the error code, now we're not mapping errors to
EFAULT and we used do... which is correct?

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>