xfs
[Top] [All Lists]

Re: [PATCH 7/9] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquot

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/9] xfs: merge xfs_qm_export_dquot into xfs_qm_scall_getquota
From: Ben Myers <bpm@xxxxxxx>
Date: Sun, 26 Feb 2012 19:57:11 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120215023148.024760659@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120215022926.577682146@xxxxxxxxxxxxxxxxxxxxxx> <20120215023148.024760659@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
Hi Christoph,

On Tue, Feb 14, 2012 at 09:29:33PM -0500, Christoph Hellwig wrote:
> The is no good reason to have these two separate, and for the next change
> I'd need the full struct xfs_dquot in xfs_qm_export_dquot, so better just
> fold the code now instead of changing it around.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

...

> -int
> -xfs_qm_scall_getquota(

...

> -     /*
> -      * Convert the disk dquot to the exportable format
> -      */
> -     xfs_qm_export_dquot(mp, &dqp->q_core, out);
> -     xfs_qm_dqput(dqp);
> -     return (error ? XFS_ERROR(EFAULT) : 0);
> -}

Note that we used to map all errors to EFAULT.

...

> +int
> +xfs_qm_scall_getquota(

...

> +out_put:
> +     xfs_qm_dqput(dqp);
> +     return error;

And, now we don't.

The rest of the patch looks great to me.  If you intend to change the
error code, please mention so in the commit message.  Was it wrong
before, or will it be wrong if we pull this in?

Regards,
Ben

<Prev in Thread] Current Thread [Next in Thread>