xfs
[Top] [All Lists]

Re: [PATCH 4/4] V2 xfs: fix deadlock in xfs_rtfree_extent with kernel v2

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 4/4] V2 xfs: fix deadlock in xfs_rtfree_extent with kernel v2.6.37
From: Kamal Dasu <kdasu.kdev@xxxxxxxxx>
Date: Sat, 25 Feb 2012 07:46:41 -0800 (PST)
In-reply-to: <20120225094030.GA3148@xxxxxxxxxxxxx>
References: <33345988.post@xxxxxxxxxxxxxxx> <33346009.post@xxxxxxxxxxxxxxx> <33346035.post@xxxxxxxxxxxxxxx> <33346043.post@xxxxxxxxxxxxxxx> <33346051.post@xxxxxxxxxxxxxxx> <20120219224118.GA31535@xxxxxxxxxxxxx> <33365485.post@xxxxxxxxxxxxxxx> <33379323.post@xxxxxxxxxxxxxxx> <20120225094030.GA3148@xxxxxxxxxxxxx>
Christoph,

I have not been able to create a simple test case for this yet.

Currently the only way I have is to use an a time shift recording
application 
that stored video streams on a real-time subvolume.  Sometimes when such
a stream is deleted I see the problem. I have not  figured out how a test to 
consistently get allocation where the bit map span multiple extents while 
freeing  the inode. 

I am still trying to come with a simple test case. 
If you have any ideas let me know I will be happy to try it out.

Kamal



Christoph Hellwig wrote:
> 
> On Thu, Feb 23, 2012 at 08:52:57AM -0800, Kamal Dasu wrote:
>> 
>> To fix the deadlock caused by recursively calling xfs_rtfree_extent
>> from xfs_bunmapi():
>> 
>>  - removed  xfs_trans_iget() from xfs_rtfree_extent(),
>>    instead added asserts that the inode is locked and has an inode_item
>>    attached to it.
>>  - in xfs_bunmapi() when dealing with an inode with the rt flag
>>    call xfs_ilock() and xfs_trans_ijoin() so that the
>>    reference count is bumped on the inode and attached it to the
>>    transaction before calling into xfs_bmap_del_extent, similar to
>>    what we do in xfs_bmap_rtalloc.
>> 
>> Signed-off-by: Kamal Dasu <kdasu.kdev@xxxxxxxxx>
> 
> This looks good, thanks a lot!
> 
> Do you have an easily reproducable testcase for this which we could
> put into xfstests?
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 
> 

-- 
View this message in context: 
http://old.nabble.com/-PATCH-0-4--RFC-xfs%3A-resurrect-realtime-subvolume-support-on-kernel-2.6.37-tp33345988p33390983.html
Sent from the Xfs - General mailing list archive at Nabble.com.

<Prev in Thread] Current Thread [Next in Thread>