xfs
[Top] [All Lists]

Re: xfsrestore will create orphanage directory when use -t

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: xfsrestore will create orphanage directory when use -t
From: Tommy Wu <wu.tommy@xxxxxxxxx>
Date: Thu, 23 Feb 2012 09:16:07 +0800
Authentication-results: mr.google.com; spf=pass (google.com: domain of wu.tommy@xxxxxxxxx designates 10.152.108.49 as permitted sender) smtp.mail=wu.tommy@xxxxxxxxx; dkim=pass header.i=wu.tommy@xxxxxxxxx
Cc: xfs <xfs@xxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=zNIJ1yCly4kGewIyOj/uq8Af5GcstluDIsuB04lj43s=; b=gB60KCfb6/ANXmRv4MlS8mdOCTH9/XzgT9KLLWtcEzzxqwaeSB9d90rkGlFDklx+8z uARdA0aAncf9gTFKV3OM5Zx9LbCtp3GXf2aofg4+e/Os87XUnP1Bf8sZY9n7y99gQurU hMFqtwk03O730gqs+R2yVgpJ1E6R6veTHNXl8=
In-reply-to: <4F45347A.2050204@xxxxxxx>
References: <CAGdb-8fC4-3swyyfP3xO=camgzDjR5GYV3qoaB1w+xAfiNeYPw@xxxxxxxxxxxxxx> <4F3EBDA6.7070108@xxxxxxx> <CAGdb-8eMcBghwznGbGQha01paF1L+MdB3QsxHCuCh6ZOW=wsag@xxxxxxxxxxxxxx> <4F45347A.2050204@xxxxxxx>
2012/2/23 Bill Kendall <wkendall@xxxxxxx>:
> On 02/17/2012 06:22 PM, Tommy Wu wrote:
>>
>> 2012/2/18 Bill Kendall<wkendall@xxxxxxx>:
>>>
>>> On 02/14/2012 11:21 AM, Tommy Wu wrote:
>>>>
>>>>
>>>> from the xfsdump man page:
>>>> xfsrestore also generates a directory named orphanage in the dest
>>>> directory. xfsrestore removes this directory after completing a simple
>>>> restore. However, if orphanage is not empty, it is not removed. This
>>>> can happen if files present on the dump media are not referenced by
>>>> any of the restored directories. The orphanage has an entry for each
>>>> such file. The entry name is the file's original inode number, a ".",
>>>> and the file's generation count modulo 4096 (only the lower 12 bits of
>>>> the generation count are used).
>>>>
>>>> and the -t option from xfsdump man page:
>>>> Displays the contents of the dump, but does not create or modify any
>>>> files or directories. It may be desirable to set the verbosity level
>>>> to silent when using this option.
>>>>
>>>> But when we use -t option with xfsrestore, it still create orphanage
>>>> directory in current directory (because no dest directory assign).
>>>> and if it's not empty, it is not removed.
>>>>
>>>> This is a bug or it's a feature?
>>>
>>>
>>>
>>> I can see code where this would happen, except that it would appear
>>> to require both -r and -t to be used, and xfsrestore doesn't allow
>>> that.
>>>
>>> If you send the command line you used I can take another look.
>>>
>>> Bill
>>
>>
>> here is the command I used for -t:
>> cat var.xfsdump.gz | gzip -dqv | xfsrestore -v silent -p 300 -J -t - |
>> grep "^xfsrestore:"
>>
>> I also test it with only -t option, it also create orphanage folder
>> for such dump file (not all dump file has this issue)
>> cat var.xfsdump.gz | gzip -dqv | xfsrestore -t - | grep "^xfsrestore:"
>
>
> I found an issue which is likely the same as what you're seeing. I'll
> post a patch shortly, please let me know whether or not it fixes the
> problem.
>
> Thanks,
> Bill

yes, after apply the patch, no such directory generated during xfsdump -t.
thanks.

-- 

Tommy Wu

<Prev in Thread] Current Thread [Next in Thread>