[Top] [All Lists]

Re: [PATCH 12/12] xfs: split and cleanup xfs_log_reserve

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/12] xfs: split and cleanup xfs_log_reserve
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 21 Feb 2012 09:18:04 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120220023154.252855704@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120220023119.435889631@xxxxxxxxxxxxxxxxxxxxxx> <20120220023154.252855704@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 02/19/12 20:31, Christoph Hellwig wrote:
Split the log regrant case out of xfs_log_reserve into a separate function,
and merge xlog_grant_log_space and xlog_regrant_write_log_space into their
respective callers.  Also replace the XFS_LOG_PERM_RESERV flag, which easily
got misused before the previous cleanups with a simple boolean parameter.

Reviewed-by: Ben Myers<bpm@xxxxxxx>
Signed-off-by: Christoph Hellwig<hch@xxxxxx>

  fs/xfs/xfs_log.c   |  198 
  fs/xfs/xfs_log.h   |    1
  fs/xfs/xfs_trace.h |    1
  fs/xfs/xfs_trans.c |   17 +++-
  4 files changed, 103 insertions(+), 114 deletions(-)

Sorry for the omission. The clean up looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>