Re: [PATCH 12/12] xfs: split and cleanup xfs_log

xfs

Re: [PATCH 12/12] xfs: split and cleanup xfs_log_reserve

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 12/12] xfs: split and cleanup xfs_log_reserve
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Tue, 21 Feb 2012 09:18:04 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120220023154.252855704@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20120220023119.435889631@xxxxxxxxxxxxxxxxxxxxxx> <20120220023154.252855704@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 02/19/12 20:31, Christoph Hellwig wrote:

Split the log regrant case out of xfs_log_reserve into a separate function,
and merge xlog_grant_log_space and xlog_regrant_write_log_space into their
respective callers.  Also replace the XFS_LOG_PERM_RESERV flag, which easily
got misused before the previous cleanups with a simple boolean parameter.

Reviewed-by: Ben Myers<bpm@xxxxxxx>
Signed-off-by: Christoph Hellwig<hch@xxxxxx>

---
  fs/xfs/xfs_log.c   |  198 
++++++++++++++++++++++++-----------------------------
  fs/xfs/xfs_log.h   |    1
  fs/xfs/xfs_trace.h |    1
  fs/xfs/xfs_trans.c |   17 +++-
  4 files changed, 103 insertions(+), 114 deletions(-)


Sorry for the omission. The clean up looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/12] log grant code cleanups V2, Christoph Hellwig [PATCH 01/12] xfs: split tail_lsn assignments from log space wakeups, Christoph Hellwig [PATCH 04/12] xfs: cleanup xfs_log_space_wake, Christoph Hellwig [PATCH 11/12] xfs: share code for grant head availability checks, Christoph Hellwig [PATCH 07/12] xfs: add xlog_grant_head_init, Christoph Hellwig [PATCH 03/12] xfs: remove xfs_trans_unlocked_item, Christoph Hellwig [PATCH 05/12] xfs: remove log space waitqueues, Christoph Hellwig [PATCH 08/12] xfs: add xlog_grant_head_wake_all, Christoph Hellwig [PATCH 06/12] xfs: add the xlog_grant_head structure, Christoph Hellwig [PATCH 12/12] xfs: split and cleanup xfs_log_reserve, Christoph Hellwig Re: [PATCH 12/12] xfs: split and cleanup xfs_log_reserve, Mark Tinguely <= [PATCH 10/12] xfs: share code for grant head wakeups, Christoph Hellwig [PATCH 02/12] xfs: do exact log space wakeups in xlog_ungrant_log_space, Christoph Hellwig [PATCH 09/12] xfs: share code for grant head waiting, Christoph Hellwig Re: [PATCH 00/12] log grant code cleanups V2, Dave Chinner

Previous by Date:	Re: [PATCH] Introduce SEEK_DATA/SEEK_HOLE support V8, Mark Tinguely
Next by Date:	[XFS updates] XFS development tree branch, for-linus, updated. v3.2-rc1-11437-gc922bbc, xfs
Previous by Thread:	[PATCH 12/12] xfs: split and cleanup xfs_log_reserve, Christoph Hellwig
Next by Thread:	[PATCH 10/12] xfs: share code for grant head wakeups, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]