[Top] [All Lists]

Re: [PATCH 8/8] xfs: add back fdatasync support

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 8/8] xfs: add back fdatasync support
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 21 Feb 2012 16:23:01 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120221003907.518904261@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120221003824.415885674@xxxxxxxxxxxxxxxxxxxxxx> <20120221003907.518904261@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 20, 2012 at 07:38:32PM -0500, Christoph Hellwig wrote:
> Add an in-memory only flag to say we logged timestamps only, and use it to
> check if fdatasync can optimize away the log force.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. Couple of minor things below.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

> +/*
> + * The timestamps in the core are dirty, but not nessecarily anything
> + * else.
> + *
> + * This is an incore only value store in ilf_fields & co, which must
> + * never make it to disk, unlike the other fields above.

That comment is a bit incoherent. Perhaps:

 * this is an incore-only flag stored in ili_fields which, unlike
 * the above flags, must never make it to disk in the ilf_fields.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>