[Top] [All Lists]

Re: [PATCH 5/8] xfs: log timestamp updates

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/8] xfs: log timestamp updates
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 21 Feb 2012 16:08:15 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120221003906.869409330@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120221003824.415885674@xxxxxxxxxxxxxxxxxxxxxx> <20120221003906.869409330@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 20, 2012 at 07:38:29PM -0500, Christoph Hellwig wrote:
> Timestamps on regular files are the last metadata that XFS does not update
> transactionally.  Now that we use the delaylog mode exclusively and made
> the log scode scale extremly well there is no need to bypass that code for
> timestamp updates.  Logging all updates allows to drop a lot of code, and
> will allow for further performance improvements later on.
> Note that this patch drops optimized handling of fdatasync - it will be
> added back in a separate commit.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. Be nice if we coulxp dreturn an error from .dirty_inode,
but we can't really do anything with it, anyway.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>