xfs
[Top] [All Lists]

Re: [PATCH 7/8] xfs: remove the per-filesystem list of dquots

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/8] xfs: remove the per-filesystem list of dquots
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 21 Feb 2012 09:15:09 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120220022904.615605871@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120220022815.018921977@xxxxxxxxxxxxxxxxxxxxxx> <20120220022904.615605871@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Feb 19, 2012 at 09:28:22PM -0500, Christoph Hellwig wrote:
> Instead of keeping a separate per-filesystem list of dquots we can walk
> the radix tree for the two places where we need to iterate all quota
> structures.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Still a bit of a lookup vs iterate hold-off remaining, but I think
we can live with the reduction now. If it proves to be a noticable
problem then we can look towards RCU based lookups, I think.
Otherwise it looks OK to me.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>