xfs
[Top] [All Lists]

Re: [patch 00/12] log grant code cleanups

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [patch 00/12] log grant code cleanups
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 19 Feb 2012 16:17:06 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120216214609.GB7762@xxxxxxx>
References: <20111212141346.986825692@xxxxxxxxxxxxxxxxxxxxxx> <20120216214609.GB7762@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 16, 2012 at 03:46:09PM -0600, Ben Myers wrote:
> Christoph,
> 
> On Mon, Dec 12, 2011 at 09:13:47AM -0500, Christoph Hellwig wrote:
> > This series removes the opportunistic log space wakeups which had no
> > use but hiding real races for far too long, and applies various bits
> > of refactoring to the log grant code to make it smaller and more readable.
> 
> This patch set looks just about ready to go.  The only changes I'd like
> to see are some commit messages where they are missing, and I have a
> question about patch 11 related to usage t_ocnt on the log ticket.

For the "share ..." commits I can't really think of any commit message
that actually makes sense - the subject seems to describe what the patch
does more than enough.

<Prev in Thread] Current Thread [Next in Thread>