xfs
[Top] [All Lists]

Re: [PATCH 2/9] xfs: use per-filesystem radix trees for dquot lookup

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/9] xfs: use per-filesystem radix trees for dquot lookup
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Feb 2012 12:38:24 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120215222111.GN14132@dastard>
References: <20120215022926.577682146@xxxxxxxxxxxxxxxxxxxxxx> <20120215023147.038502020@xxxxxxxxxxxxxxxxxxxxxx> <20120215222111.GN14132@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 16, 2012 at 09:21:11AM +1100, Dave Chinner wrote:
> qi->qi_tree_lock, as the local variable is already set up.

Indeed.

> > +   struct radix_tree_root *tree = XFS_DQUOT_TREE(mp, type);
> > +   struct xfs_dquot        *dqp;
> > +   int                     error;
> 
> Add a quotainfo local variable and use it in the function?

Yes, that's a good idea.

> qi->qi_tree_lock as it is already there and used for all the other
> quotainfo references.

Indeed.

I've fixed all these up, and also changed the XFS_DQUOT_TREE macro
to take a quotainfo pointer instead of a mount pointer.

<Prev in Thread] Current Thread [Next in Thread>