xfs
[Top] [All Lists]

Re: [PATCH 1/9] xfs: use per-filesystem dquot LRU lists

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/9] xfs: use per-filesystem dquot LRU lists
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Feb 2012 12:33:48 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120215221045.GM14132@dastard>
References: <20120215022926.577682146@xxxxxxxxxxxxxxxxxxxxxx> <20120215023146.847910539@xxxxxxxxxxxxxxxxxxxxxx> <20120215221045.GM14132@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 16, 2012 at 09:10:45AM +1100, Dave Chinner wrote:
> Might be nice to add a
> 
> +     struct xfs_quotainfo    *qi = dqp->q_mount->m_quotainfo;
> 
> here  to make the code a little easier to read and consistent with
> all the other functions.
> 
> Regardless, change looks good.

Makes sense.  I've done that and actually split the real final put
into a separate xfs_qm_dqput_final function, and replaced the tail
recursion with a real recursive call to xfs_qm_dqput for the group
quota.  Given that this is a fairly large amount of changes I didn't
bother to add your reviewed by tag until it's getting re-reviewed.

<Prev in Thread] Current Thread [Next in Thread>