xfs
[Top] [All Lists]

Re: [PATCH] xfs_fsr: Get the last mount on a specific mount point

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_fsr: Get the last mount on a specific mount point
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Feb 2012 12:26:39 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120215123143.GA22051@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1328640076-12645-1-git-send-email-cmaiolino@xxxxxxxxxx> <20120213174240.GA3474@xxxxxxxxxxxxx> <20120215123143.GA22051@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Feb 15, 2012 at 10:31:43AM -0200, Carlos Maiolino wrote:
> I would change a little this sentence, looks a little confusing at least for 
> me.
> How about:
> 
>               /* If we found an entry based on the device name, make sure we
>                * stat the mount point given by mtab and ensure it's accessible
>                * before using it.
>                */

Agreed, I'll redo it.

> > +                   if (S_ISLNK(sb.st_mode)) {
> > +                           struct stat64 sb2;
> 
> Particularly, I don't like variable declarations between statements, but I'm 
> not
> too experienced to say what's good or not :)

The idea is to keep variable declarations as local as possible.

<Prev in Thread] Current Thread [Next in Thread>